Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1707

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
def format_linter_error(error: dict) -> dict:
# write your code here
pass
from calendar import error
from idlelib.iomenu import errors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have imported the error from calendar but it is not used anywhere in your code. It is a good practice to remove unused imports to keep the code clean and understandable. This is a code quality issue.


CryptoQwest marked this conversation as resolved.
Show resolved Hide resolved

def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass
def format_linter_error(error: dict) -> dict:
return {
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"
}

def format_single_linter_file(file_path: str, errors: list) -> dict:
return {
errors: [format_linter_error(error) for error in errors],
"path": file_path,
CryptoQwest marked this conversation as resolved.
Show resolved Hide resolved
"status": "failed" if errors else "passed"
}

CryptoQwest marked this conversation as resolved.
Show resolved Hide resolved
def format_linter_report(linter_report: dict) -> list:
# write your code here
pass
return [
format_single_linter_file(file_path, errors)
for file_path, errors in linter_report.items()
]
Loading