-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1720
base: master
Are you sure you want to change the base?
Solution #1720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the pull request! 🎉 While there are some instances of code duplication, they don't critically impact the functionality. Consider refactoring to use the format_linter_error
function to make your code cleaner and more maintainable in the future. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
app/main.py
Outdated
return { | ||
"errors": [ | ||
{ | ||
"line": error["line_number"], | ||
"column": error["column_number"], | ||
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} | ||
for error in errors | ||
], | ||
"path": file_path, | ||
"status": "passed" if errors == [] else "failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block from line 12 to line 24 duplicates the logic of the format_linter_error
function. According to the checklist, you should use the format_linter_error
function to avoid code duplication.
app/main.py
Outdated
return [{ | ||
"errors": [ | ||
{ | ||
"line": error["line_number"], | ||
"column": error["column_number"], | ||
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} for error in linter_report[file_path]], | ||
"path": file_path, | ||
"status": "passed" if linter_report[file_path] == [] else "failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block from line 29 to line 39 also duplicates the logic of the format_linter_error
function. As per the checklist, you should use the format_linter_error
function to avoid repeating code.
app/main.py
Outdated
return { | ||
"errors": [ | ||
{ | ||
"line": error["line_number"], | ||
"column": error["column_number"], | ||
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} | ||
for error in errors | ||
], | ||
"path": file_path, | ||
"status": "passed" if errors == [] else "failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block from line 12 to line 24 duplicates the logic of the format_linter_error
function. According to the checklist, you should use the format_linter_error
function to avoid code duplication.
app/main.py
Outdated
return [{ | ||
"errors": [ | ||
{ | ||
"line": error["line_number"], | ||
"column": error["column_number"], | ||
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} for error in linter_report[file_path]], | ||
"path": file_path, | ||
"status": "passed" if linter_report[file_path] == [] else "failed" | ||
} for file_path in linter_report] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block from line 29 to line 39 also duplicates the logic of the format_linter_error
function. As per the checklist, you should use the format_linter_error
function to avoid repeating code.
No description provided.