Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution. "Mate-formatting" for reports, files and errors #1729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution. "Mate-formatting" for reports, files and errors #1729

wants to merge 1 commit into from

Conversation

4ikkamony
Copy link

No description provided.

@dottfmar
Copy link

Everything is okay. Formatting is up to the standard, and all the tests have passed.

dottfmar
dottfmar approved these changes Oct 21, 2024
View reviewed changes
app/main.py
"errors": [format_linter_error(error) for error in errors],
"path": file_path,
"status": "failed" if len(errors) > 0 else "passed"
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment:
You can also check if list has items using "if errors" instead "if len(errors)" for less code)

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Oct 21, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! The code is well-structured and meets the task requirements. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@dottfmar dottfmar dottfmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4ikkamony @dottfmar @mateacademy-ai-mentor