Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function #1730

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add function #1730

wants to merge 2 commits into from

Conversation

bogdna21
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the code! While there's a minor issue with code duplication, it doesn't affect the functionality. Consider refactoring to adhere to the 'Don't Repeat Yourself' principle in the future. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated
Comment on lines 14 to 20
{
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block from lines 14 to 20 duplicates the logic of the 'format_linter_error' function. According to the checklist, you should use the 'format_linter_error' function to avoid code duplication.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants