tymofii hriniuk #1733
tymofii hriniuk #1733
Conversation
add timeout to tests
README.md rewritten in English
explanation added to functions
improved tests
There was a problem hiding this comment.
Great job on the code! 🎉 While there are a few stylistic and optimization suggestions, they don't impact the core functionality. Keep up the good work and consider the feedback for future improvements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -2,6 +2,7 @@ | |||
| import ast | |||
| import inspect | |||
|
|
|||
| from app import main | |||
There was a problem hiding this comment.
The import statement for main from app is not used in the code. Consider removing it to adhere to the DRY principle and avoid unnecessary imports.
| def test_comment_deleted(): | ||
| lines = inspect.getsource(main) | ||
| assert "# write your code here" not in lines, ( | ||
| "Remove the unnecessary" " comment '# write your code here'" | ||
| ) |
There was a problem hiding this comment.
The test test_comment_deleted is checking for a specific comment in the source code. Ensure that this comment is indeed unnecessary and should be removed according to the task requirements.
| def test_double_quotes_instead_of_single(): | ||
| lines = inspect.getsource(main) | ||
| assert "'" not in lines, ( | ||
| 'You have to use a double quotes "" instead' " of single ''" | ||
| ) |
There was a problem hiding this comment.
The test test_double_quotes_instead_of_single is enforcing the use of double quotes over single quotes. Make sure this requirement is specified in the task description or checklist, as it might be a stylistic preference rather than a functional requirement.
My opinion its best code and programing in the world