-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tymofii hriniuk #1733
base: add_timeout
Are you sure you want to change the base?
tymofii hriniuk #1733
Conversation
add timeout to tests
README.md rewritten in English
explanation added to functions
improved tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the code! 🎉 While there are a few stylistic and optimization suggestions, they don't impact the core functionality. Keep up the good work and consider the feedback for future improvements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -2,6 +2,7 @@ | |||
import ast | |||
import inspect | |||
|
|||
from app import main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement for main
from app
is not used in the code. Consider removing it to adhere to the DRY principle and avoid unnecessary imports.
def test_comment_deleted(): | ||
lines = inspect.getsource(main) | ||
assert "# write your code here" not in lines, ( | ||
"Remove the unnecessary" " comment '# write your code here'" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test test_comment_deleted
is checking for a specific comment in the source code. Ensure that this comment is indeed unnecessary and should be removed according to the task requirements.
def test_double_quotes_instead_of_single(): | ||
lines = inspect.getsource(main) | ||
assert "'" not in lines, ( | ||
'You have to use a double quotes "" instead' " of single ''" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test test_double_quotes_instead_of_single
is enforcing the use of double quotes over single quotes. Make sure this requirement is specified in the task description or checklist, as it might be a stylistic preference rather than a functional requirement.
My opinion its best code and programing in the world