Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

'Solution' #692

wants to merge 2 commits into from

Conversation

Lebwa1337
Copy link

No description provided.

app/main.py Outdated
Comment on lines 3 to 6
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's preferable to use get() method instead of parenthesis everywhere for getting value by key to avoid KeyError

Copy link

@Dimosphen1 Dimosphen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants