-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #694
base: master
Are you sure you want to change the base?
Solution #694
Conversation
app/main.py
Outdated
"line": error["line_number"], | ||
"column": error["column_number"], | ||
"message": error["text"], | ||
"name": error["code"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's preferable to use get() method instead of parenthesis everywhere for getting value by key to avoid KeyError
app/main.py
Outdated
return [format_single_linter_file(path, errors) | ||
for path, errors in linter_report.items() | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return [format_single_linter_file(path, errors) | |
for path, errors in linter_report.items() | |
] | |
return [ | |
format_single_linter_file(path, errors) | |
for path, errors in linter_report.items() | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.