Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #709

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Dev #709

wants to merge 11 commits into from

Conversation

DimaPr7
Copy link

@DimaPr7 DimaPr7 commented Jul 17, 2023

No description provided.

Copy link

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove pycache from gihub

app/main.py Outdated
def format_linter_error(error: dict) -> dict:
# write your code here
pass
def format_linter_error(error: list) -> list:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def format_linter_error(error: list) -> list:
def format_linter_error(error: list) -> dict:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

@DimaPr7 DimaPr7 requested a review from vsmutok July 17, 2023 19:10
app/main.py Outdated
def format_linter_error(error: dict) -> dict:
# write your code here
pass
def format_linter_error(error: list) -> list:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete pychache

app/main.py Outdated
def format_linter_error(error: dict) -> dict:
# write your code here
pass
def format_linter_error(error: dict) -> list:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def format_linter_error(error: dict) -> list:
def format_linter_error(error: dict) -> dict:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it

Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
you must delete this tests/__pycache__ and __pycache__ folders from commit

Copy link

@ArsenPidhoretskyi ArsenPidhoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants