-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter formatter done #711
base: master
Are you sure you want to change the base?
Conversation
app/main.py
Outdated
[ | ||
format_linter_error(err) | ||
for err in errors | ||
if err["filename"] == file_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is redundant remove it
app/main.py
Outdated
"errors": | ||
[ | ||
format_linter_error(err) | ||
for err in errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename err to error
app/main.py
Outdated
"status": "failed" | ||
if any(err["filename"] == file_path for err in errors) | ||
else "passed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"status": "failed" | |
if any(err["filename"] == file_path for err in errors) | |
else "passed" | |
"status": "failed" if errors else "passed" |
main.py
Outdated
@@ -0,0 +1,16 @@ | |||
# This is a sample Python script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete please
No description provided.