Solution #723
Open
Solution #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2023 17:15
Bohdan-Salamakha
suggested changes
Jul 26, 2023
app/main.py
Outdated
Comment on lines
3
to
6
| "line": error["line_number"], | ||
| "column": error["column_number"], | ||
| "message": error["text"], | ||
| "name": error["code"], |
There was a problem hiding this comment.
it's preferable to use get() method instead of parenthesis everywhere for getting value by key to avoid KeyError
app/main.py
Outdated
Comment on lines
13
to
22
| "errors": [ | ||
| { | ||
| "line": error["line_number"], | ||
| "column": error["column_number"], | ||
| "message": error["text"], | ||
| "name": error["code"], | ||
| "source": "flake8" | ||
| } | ||
| for error in errors | ||
| ], |
There was a problem hiding this comment.
use format_linter_error() function here
app/main.py
Outdated
Comment on lines
30
to
43
| { | ||
| "errors": [ | ||
| { | ||
| "line": error["line_number"], | ||
| "column": error["column_number"], | ||
| "message": error["text"], | ||
| "name": error["code"], | ||
| "source": "flake8" | ||
| } | ||
| for error in file_errors | ||
| ], | ||
| "path": file_path, | ||
| "status": "failed" if file_errors else "passed" | ||
| } |
There was a problem hiding this comment.
use format_single_linter_file() function here
added 2 commits
July 26, 2023 20:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a nice day)