Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (py-linter-formatter) without long lines #728

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baranovr
Copy link

No description provided.

app/main.py Outdated
def format_linter_error(error: dict) -> dict:
# write your code here
pass
def format_linter_error(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to wrap arguments on a new line if the length of the line with all the arguments does not satisfy the rules of flake8 or PEP8

app/main.py Outdated
def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass
def format_single_linter_file(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to wrap arguments on a new line if the length of the line with all the arguments does not satisfy the rules of flake8 or PEP8

app/main.py Outdated
def format_linter_report(linter_report: dict) -> list:
# write your code here
pass
def format_linter_report(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to wrap arguments on a new line if the length of the line with all the arguments does not satisfy the rules of flake8 or PEP8

Copy link

@Dimosphen1 Dimosphen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants