Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #764

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #764

wants to merge 3 commits into from

Conversation

Depaton
Copy link

@Depaton Depaton commented Aug 6, 2023

No description provided.

app/main.py Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@Depaton
Copy link
Author

Depaton commented Aug 6, 2023

I change solution as You comment.

Copy link
Author

@Depaton Depaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New solution

@Depaton Depaton closed this Aug 6, 2023
@Depaton Depaton reopened this Aug 6, 2023
Copy link
Author

@Depaton Depaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution

@Depaton Depaton closed this Aug 7, 2023
@Depaton Depaton reopened this Aug 7, 2023
Copy link
Author

@Depaton Depaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check please.

app/main.py Outdated
# write your code here
pass
return {
"errors": [format_linter_error(num) for num in errors],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why num? this is an error

app/main.py Outdated
Comment on lines 21 to 22
format_single_linter_file(key, linter_report[key])
for key in linter_report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that is key? you can use .items method to unpack

Copy link

@Polyakiv-Andrey Polyakiv-Andrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants