implement py-tickets-orders #650
Conversation
cinema_service/settings.py
Outdated
| REST_FRAMEWORK = { | ||
| "DEFAULT_PAGINATION_CLASS": | ||
| "rest_framework.pagination.LimitOffsetPagination", | ||
| "PAGE_SIZE": 10 |
There was a problem hiding this comment.
I recommend you to delete this and write your own custom paginator. It will be very easy, if you watched and read the lessons carefully ofc)
Moreover, try to use this new paginator ONLY with OrderViewSet. Because otherwise tests will fail :(
cinema/serializers.py
Outdated
| class OrderSetPagination(PageNumberPagination): | ||
| page_size = 1 | ||
| page_size_query_param = "page_size" | ||
| max_page_size = 10 |
There was a problem hiding this comment.
I think it will be much better to replace this class into a separate module (paginators.py in the same directory ofc)
cinema/paginators.py
Outdated
| class OrderSetPagination(PageNumberPagination): | ||
| page_size = 1 | ||
| page_size_query_param = "page_size" | ||
| max_page_size = 10 |
There was a problem hiding this comment.
page_size = 1
I think it's better to give at least 5
| fields = ("id", "row", "seat", "movie_session") | ||
|
|
||
| def validate(self, attrs): | ||
| Ticket.validate_seat_and_row( |
There was a problem hiding this comment.
better call super() here and save the result, then after validation return result
There was a problem hiding this comment.
This to be 100% sure that you return the same thing that is in the parent class
cinema/serializers.py
Outdated
| class MovieSessionDetailSerializer(MovieSessionSerializer): | ||
| movie = MovieListSerializer(many=False, read_only=True) | ||
| cinema_hall = CinemaHallSerializer(many=False, read_only=True) | ||
| taken_places = SerializerMethodField() |
There was a problem hiding this comment.
You can use nested serializer here - create TicketSeatsSerializer with row / seat fields and pass it to taken_places
cinema/views.py
Outdated
| queryset = queryset.filter(title__icontains=title) | ||
|
|
||
| elif self.action == "retrieve": | ||
| queryset = queryset.prefetch_related("genres", "actors") |
There was a problem hiding this comment.
you already prefetch above - no need to do it twice
cinema/views.py
Outdated
| if date: | ||
| queryset = queryset.filter(show_time__date=date) | ||
|
|
||
| if self.action in "retrieve": |
There was a problem hiding this comment.
should be == Right now it will try to match self.action vs every character in a string
cinema/views.py
Outdated
| queryset = queryset.filter(title__icontains=title) | ||
|
|
||
| elif self.action == "retrieve": | ||
| queryset = queryset |
cinema/views.py
Outdated
| def get_queryset(self): | ||
| queryset = self.queryset.filter(user=self.request.user) | ||
| if self.action == "list": | ||
| queryset = queryset.prefetch_related("tickets__movie_session") |
There was a problem hiding this comment.
here would be better to specifically prefetch "tickets__movie_session__movie", "tickets__movie_session__cinema_hall"
cinema/serializers.py
Outdated
|
|
||
|
|
||
| class TicketRetrieveSerializer(TicketSerializer): | ||
| movie_session = MovieSessionListSerializer(many=False, read_only=True) |
cinema/serializers.py
Outdated
| order = Order.objects.create(**validated_data) | ||
| for ticket_data in tickets_data: | ||
| Ticket.objects.create(order=order, **ticket_data) | ||
| return order |
There was a problem hiding this comment.
In create/update/delete fucntion you don't need return anything
cinema/views.py
Outdated
| @@ -56,3 +85,53 @@ def get_serializer_class(self): | |||
| return MovieSessionDetailSerializer | |||
|
|
|||
| return MovieSessionSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = self.queryset | |||
There was a problem hiding this comment.
call super method instead of accesing this attribute directly
No description provided.