first #657
Open
first #657
+218
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexandr-Politov
suggested changes
Oct 3, 2024
|
|
||
|
|
||
| class TicketRetrieveSerializer(TicketSerializer): | ||
| movie_session = MovieSessionListSerializer(many=False, read_only=True) |
There was a problem hiding this comment.
False is a default value, thus you can remove it
oliasymak24
suggested changes
Oct 8, 2024
| order = Order.objects.create(**validated_data) | ||
| for ticket_data in tickets_data: | ||
| Ticket.objects.create(order=order, **ticket_data) | ||
| return order |
There was a problem hiding this comment.
In create/update/delete function you don't need return anything
cinema/views.py
Outdated
| genres_ids = [int(str_id) for str_id in genres.split(",")] | ||
| queryset = queryset.filter(genres__id__in=genres_ids) | ||
| if actors: | ||
| actors_ids = [int(str_id) for str_id in actors.split(",")] |
cinema/views.py
Outdated
Comment on lines
43
to
53
| actors = self.request.query_params.get("actors") | ||
| genres = self.request.query_params.get("genres") | ||
| title = self.request.query_params.get("title") | ||
| if genres: | ||
| genres_ids = [int(str_id) for str_id in genres.split(",")] | ||
| queryset = queryset.filter(genres__id__in=genres_ids) | ||
| if actors: | ||
| actors_ids = [int(str_id) for str_id in actors.split(",")] | ||
| queryset = queryset.filter(actors__id__in=actors_ids) | ||
| if title: | ||
| queryset = queryset.filter(title__icontains=title) |
There was a problem hiding this comment.
This part must be evaluated if self.actions == "list"
Oleksl888
suggested changes
Oct 22, 2024
cinema/views.py
Outdated
| genres_ids = [int(str_id) for str_id in genres.split(",")] | ||
| queryset = queryset.filter(genres__id__in=genres_ids) | ||
| if actors: | ||
| actors_ids = [int(str_id) for str_id in actors.split(",")] |
cinema/views.py
Outdated
| def get_queryset(self): | ||
| queryset = self.queryset.prefetch_related("genres", "actors") | ||
|
|
||
| genres = self.request.query_params.get("genres") |
There was a problem hiding this comment.
you need to do filter by query params only on list action
cinema/views.py
Outdated
| ) | ||
| ) | ||
|
|
||
| movie_id = self.request.query_params.get("movie") |
There was a problem hiding this comment.
same here - filtering is needed only on list action
oliasymak24
suggested changes
Oct 23, 2024
| title = self.request.query_params.get("title") | ||
|
|
||
| if genres: | ||
| genres_ids = [int(str_id) for str_id in genres.split(",")] |
There was a problem hiding this comment.
You didn't change previous comments
|
|
||
|
|
||
| class TicketRetrieveSerializer(TicketSerializer): | ||
| movie_session = MovieSessionListSerializer(many=False, read_only=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.