implement py-tickets-orders #665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpiuro
approved these changes
Oct 4, 2024
oliasymak24
suggested changes
Oct 8, 2024
cinema/serializers.py
Outdated
| order=order, **ticket_data | ||
| ) for ticket_data in tickets_data | ||
| ) | ||
| return order |
There was a problem hiding this comment.
In create/update/delete function you don't need to return anything
cinema/serializers.py
Outdated
Comment on lines
134
to
136
| Ticket( | ||
| order=order, **ticket_data | ||
| ) for ticket_data in tickets_data |
cinema/views.py
Outdated
|
|
||
| if actors: | ||
| queryset = queryset.filter( | ||
| actors__id__in=actors.split(",") |
There was a problem hiding this comment.
Seems you need to convert it to int
Oleksl888
suggested changes
Oct 22, 2024
cinema/serializers.py
Outdated
| fields = ("id", "order", "row", "seat", "movie_session") | ||
|
|
||
|
|
||
| class OrderSerializer(serializers.ModelSerializer): |
There was a problem hiding this comment.
Double check the requirements - you need to have different Serializers for POST and GET methods.
cinema/views.py
Outdated
| return MovieSessionSerializer | ||
|
|
||
|
|
||
| class OrderSetPagination(PageNumberPagination): |
There was a problem hiding this comment.
better structure if you put pagination in separate file
| queryset = Order.objects.all() | ||
| serializer_class = OrderSerializer | ||
| pagination_class = OrderSetPagination | ||
|
|
There was a problem hiding this comment.
get_serializer_class will need to be implemented here after you add another OrderSerializer
db.sqlite3
Outdated
|
|
||
| if self.action == "list": | ||
| queryset = queryset.prefetch_related( | ||
| "tickets__movie_session__movie", |
There was a problem hiding this comment.
you will need to prefetch on detail action as well
oliasymak24
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.