Solution #671
Open
Solution #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihorutkin
reviewed
Oct 6, 2024
| class MovieSessionDetailSerializer(MovieSessionSerializer): | ||
| movie = MovieListSerializer(many=False, read_only=True) | ||
| cinema_hall = CinemaHallSerializer(many=False, read_only=True) | ||
| taken_places = TicketListSerializer(many=True, source="tickets") |
There was a problem hiding this comment.
I think here you can add read_only = True
ihorutkin
reviewed
Oct 6, 2024
cinema/views.py
Outdated
Comment on lines
140
to
141
| if self.action == "retrieve": | ||
| return OrderSerializer |
ihorutkin
reviewed
Oct 6, 2024
|
|
||
|
|
||
| class OrderViewSet(viewsets.ModelViewSet): | ||
| queryset = Order.objects.all() |
There was a problem hiding this comment.
It may sense to use prefetch_related here
ihorutkin
approved these changes
Oct 6, 2024
MNDonut
suggested changes
Oct 11, 2024
cinema/views.py
Outdated
| return OrderListSerializer | ||
|
|
||
| if self.action == "retrieve": | ||
| return OrderSerializer |
There was a problem hiding this comment.
return self.serializer_class because otherwise it's pointless to set serializer_class attribute in this case
cinema/serializers.py
Outdated
|
|
||
|
|
||
| class TicketDetailSerializer(TicketSerializer): | ||
| movie_session = MovieSessionSerializer(many=False, read_only=False) |
There was a problem hiding this comment.
False is a default value for both params
| class TicketDetailSerializer(TicketSerializer): | ||
| movie_session = MovieSessionSerializer(many=False, read_only=False) | ||
|
|
||
|
|
||
| class MovieSessionDetailSerializer(MovieSessionSerializer): | ||
| movie = MovieListSerializer(many=False, read_only=True) | ||
| cinema_hall = CinemaHallSerializer(many=False, read_only=True) |
There was a problem hiding this comment.
False is a default value for this param
cinema/views.py
Outdated
| @@ -34,6 +38,25 @@ class MovieViewSet(viewsets.ModelViewSet): | |||
| queryset = Movie.objects.all() | |||
| serializer_class = MovieSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = self.queryset | |||
cinema/views.py
Outdated
| @@ -48,11 +71,73 @@ class MovieSessionViewSet(viewsets.ModelViewSet): | |||
| queryset = MovieSession.objects.all() | |||
| serializer_class = MovieSessionSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = self.queryset | |||
cinema/views.py
Outdated
| def get_serializer_class(self): | ||
| if self.action == "list": | ||
| return MovieSessionListSerializer | ||
|
|
||
| if self.action == "create": | ||
| return MovieSessionListPOSTSerializer | ||
|
|
||
| if self.action == "retrieve": | ||
| return MovieSessionDetailSerializer | ||
|
|
||
| return MovieSessionSerializer |
cinema/views.py
Outdated
| pagination_class = OrderSetPagination | ||
|
|
||
| def get_queryset(self): | ||
| queryset = self.queryset.filter(user=self.request.user) |
Oleksl888
reviewed
Oct 22, 2024
| return self.serializer_class | ||
|
|
||
|
|
||
| class OrderSetPagination(PageNumberPagination): |
There was a problem hiding this comment.
better to put this in separate file to better structure code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.