solution #117
Open
solution #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zibi95
suggested changes
Sep 30, 2024
src/fillTank.test.js
Outdated
Comment on lines
26
to
44
| it(`should ordered full tank if amount is not given`, () => { | ||
| const customer = { | ||
| money: 3000, | ||
| vehicle: { | ||
| maxTankCapacity: 40, | ||
| fuelRemains: 10, | ||
| }, | ||
| }; | ||
|
|
||
| fillTank(customer, 5); | ||
|
|
||
| expect(customer).toEqual({ | ||
| money: 2850, | ||
| vehicle: { | ||
| maxTankCapacity: 40, | ||
| fuelRemains: 40, | ||
| }, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
The test named should ordered full tank if amount is not given does not actually handle the "full tank" scenario if no amount is passed. It calls fillTank(customer, 5)
There was a problem hiding this comment.
I do not understand you, default value for amount is Infinity
src/fillTank.test.js
Outdated
Comment on lines
106
to
146
| it(`should round the poured amount by discarding | ||
| number to the tenth part`, () => { | ||
| const customer = { | ||
| money: 3000, | ||
| vehicle: { | ||
| maxTankCapacity: 40, | ||
| fuelRemains: 8, | ||
| }, | ||
| }; | ||
|
|
||
| fillTank(customer, 5, 4.67); | ||
|
|
||
| expect(customer).toEqual({ | ||
| money: 2977, | ||
| vehicle: { | ||
| maxTankCapacity: 40, | ||
| fuelRemains: 12.6, | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| it(`should round the price of the purchased fuel | ||
| the to the nearest hundredth part.`, () => { | ||
| const customer = { | ||
| money: 3000, | ||
| vehicle: { | ||
| maxTankCapacity: 40, | ||
| fuelRemains: 8, | ||
| }, | ||
| }; | ||
|
|
||
| fillTank(customer, 5.12, 4.6); | ||
|
|
||
| expect(customer).toEqual({ | ||
| money: 2976.45, | ||
| vehicle: { | ||
| maxTankCapacity: 40, | ||
| fuelRemains: 12.6, | ||
| }, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Multiple test cases are similar or overlapping in their goals. For example, should round the poured amount by discarding number to the tenth part and should round the price of the purchased fuel to the nearest hundredth part could be combined into a more holistic test if the goal is to check rounding behavior.
natalia-klonowska
suggested changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.