Develop #37
Open
Develop #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilWeda
suggested changes
Sep 10, 2024
| </span> | ||
| </div> | ||
|
|
||
| <!-- <p class="help is-danger">error message</p> --> |
Comment on lines
+59
to
+75
| const indexToRemove = this.comments.findIndex(comment => comment.id === commentId); | ||
|
|
||
| if (indexToRemove === -1) { | ||
| return; | ||
| } | ||
|
|
||
| const commentToRemove = this.comments[indexToRemove]; | ||
| this.comments.splice(indexToRemove, 1); | ||
|
|
||
| deleteComment(commentId) | ||
| .then((res) => { | ||
| console.log('success', res.data); | ||
| }) | ||
| .catch((error) => { | ||
| this.comments.splice(indexToRemove, 0, commentToRemove); | ||
| console.error('Failed to delete comment:', error); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const indexToRemove = this.comments.findIndex(comment => comment.id === commentId); | |
| if (indexToRemove === -1) { | |
| return; | |
| } | |
| const commentToRemove = this.comments[indexToRemove]; | |
| this.comments.splice(indexToRemove, 1); | |
| deleteComment(commentId) | |
| .then((res) => { | |
| console.log('success', res.data); | |
| }) | |
| .catch((error) => { | |
| this.comments.splice(indexToRemove, 0, commentToRemove); | |
| console.error('Failed to delete comment:', error); | |
| }); | |
| this.comments = this.comments.filter(comment => comment.id !== commentId); | |
| deleteComment(commentId) | |
| .then((res) => { | |
| console.log('success', res.data); | |
| }) | |
| .catch((error) => { | |
| this.comments.splice(indexToRemove, 0, commentToRemove); | |
| console.error('Failed to delete comment:', error); | |
| }); |
Maybe I missed something, but as I see we can simplify
| </div> | ||
| </div> | ||
|
|
||
| <Sidebar class="Sidebar" :class="{ 'Sidebar--open': currentPostId !== 0 || showPostForm || isEditing }" :style="{'flex': '1 1 0%', 'padding-right': '10px'}"> |
There was a problem hiding this comment.
currentPostId !== 0 || showPostForm || isEditing
It`s can be constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO