Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #40

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Develop #40

wants to merge 3 commits into from

Conversation

FoReWwEr
Copy link

@FoReWwEr FoReWwEr commented Sep 7, 2024

https://ForeWwEr.github.io/vue_dynamic-list-of-posts

good afternoon, regarding the styles, I couldn't find the ones I needed, so I used what was available

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
The author and post body cannot be only spaces, you need to fix it
image

Comment on lines 29 to 30
<input type="text" name="name" id="comment-author-name-name"
placeholder="Name Surname" class="input" v-model="name" minlength="3" required>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix code styles everywhere

Suggested change
<input type="text" name="name" id="comment-author-name-name"
placeholder="Name Surname" class="input" v-model="name" minlength="3" required>
<input
type="text"
name="name"
id="comment-author-name-name"
placeholder="Name Surname"
class="input"
v-model="name"
minlength="3"
required
>

<template>
<tr>
<td>{{ post.id }}</td>
<td>{{ post.title }}</td>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use destructuring for post

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the demo link still not fixed from the previous review, you need to make a deploy again after your changes and check it on the demo link
image

@FoReWwEr
Copy link
Author

FoReWwEr commented Sep 7, 2024

Hi, the demo link still not fixed from the previous review, you need to make a deploy again after your changes and check it on the demo link image

sorry :(

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants