Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pawelnowicki87
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on setting up the project! 🎉 The code meets the task requirements and is well-structured. While there are minor improvements suggested, such as reviewing the commented-out fields in the createUser function and removing unnecessary console logs in updatePost, these do not impact the overall functionality. Keep up the good work and consider these suggestions for future enhancements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +11 to +13
export const updatePost = async (data) => {
console.log(data);
return client.patch(`/posts/${data.id}`, data);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updatePost function logs the data to the console, which might be unnecessary for production code. Consider removing the console.log(data); line if it's not needed for debugging purposes.

Comment on lines +11 to +12
// username: '',
// phone: '',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The createUser function has commented-out fields username and phone. If these fields are required or optional for user creation, consider uncommenting them and providing appropriate values. Otherwise, ensure that their omission is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants