Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed task #56

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Completed task #56

wants to merge 13 commits into from

Conversation

k-marchuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a critical issue with the USER_ID variable in the posts.js file, which is not defined or imported. This needs to be addressed to ensure the functionality works as expected. Once this is resolved, your implementation will be in great shape! Keep up the good work and feel free to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/api/posts.js Outdated

export const addPost = async postData => {
const response = await client.post(`/posts`, {
userId: USER_ID,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The USER_ID variable is used here but is not defined or imported in this file. You need to define it or import it from the appropriate module to ensure this function works correctly.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code meets the task requirements and constraints, and all necessary files are present. The posts.js file now correctly utilizes the USER_ID variable, resolving the previous issue. Your implementation adheres to the task description, and no changes are necessary across the files reviewed.

While there are no critical issues, always strive to review any comments for potential improvements. This will help you enhance your skills and produce even better code in the future. Keep up the great work and continue learning from each experience! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Copy link

@DanilWeda DanilWeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Approved.
Many thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants