Improve search system #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shell: Add EvFindSidebar widget to show search results see https://gitlab.gnome.org/GNOME/evince/-/commit/940ce8048e4fc6503dca03c1ce090ff4a11dface eggfindbar: don't close the findbar when it loses the focus see https://gitlab.gnome.org/GNOME/evince/-/commit/a2d781fb124bd19861035fd41dacc976e00d19ef shell: Add the findbar to the main box instead of the view box libview: Add ev_view_find_set_result
|
I tried to back port the same functionality 2 years ago or so. So i like this. |
raveit65
reviewed
Jun 10, 2021
| @@ -72,6 +72,9 @@ void ev_view_zoom (EvView *view, | |||
| /* Find */ | |||
| void ev_view_find_next (EvView *view); | |||
| void ev_view_find_previous (EvView *view); | |||
| void ev_view_find_set_result (EvView *view, | |||
| gint page, | |||
raveit65
reviewed
Jun 10, 2021
| @@ -5729,6 +5771,15 @@ attachment_bar_menu_popup_cb (EvSidebarAttachments *attachbar, | |||
| return TRUE; | |||
| } | |||
|
|
|||
| static void | |||
| find_sidebar_result_activated_cb (EvFindSidebar *find_sidebar, | |||
| gint page, | |||
|
Beside from a few code-style issues it works fine, thanks. |
|
This does not work with epub documents yet... |
|
@mbkma |
|
Opps, cross posting :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell: Add EvFindSidebar widget to show search results
see https://gitlab.gnome.org/GNOME/evince/-/commit/940ce8048e4fc6503dca03c1ce090ff4a11dface
eggfindbar: don't close the findbar when it loses the focus
see https://gitlab.gnome.org/GNOME/evince/-/commit/a2d781fb124bd19861035fd41dacc976e00d19ef
shell: Add the findbar to the main box instead of the view box
libview: Add ev_view_find_set_result
Fixes #238