Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

battstat: call up_client_get_devices once to avoid mem leak #443

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

battstat: call up_client_get_devices once to avoid mem leak #443

wants to merge 5 commits into from

Commits on Feb 26, 2020

  1. battstat: call up_client_get_devices once to avoid mem leak 

    This attempts to avoid a memory leak when calling
up_client_get_devices() from libupower-glib by only calling it once
in battstat_upower_initialise() and reusing that GPtrArray later in
battstat_upower_get_battery_info().

This leak was discovered by running strace for mmap and brk syscalls.
No calls to mmap were made, but the brk could caught and backtraced
over and over again to battstat_upower_get_battery_info().

There may be some issues with UP_CHECK_VERSION (0, 99, 0) checks that
need to be addressed here that are made in battstat_upower_initialise(),
but not in battstat_upower_get_battery_info().

See 'Memory leak of battstat-applet mate-desktop#345' for more details:
mate-desktop#345
    Alex Wilson committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    2991bc7 View commit details
    Browse the repository at this point in the history

  2. battstat: remove whitespace noise; free devices ptr in cleanup func

    Alex Wilson committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    a73baf2 View commit details
    Browse the repository at this point in the history

  3. battstat: use more specific unref for devices ptr; rearrange cleanup

    Alex Wilson committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    591ebcc View commit details
    Browse the repository at this point in the history

  4. battstat: bump upower version; update depricated funcs and remove upo… 

    …wer version checks
    Alex Wilson committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    135c7c4 View commit details
    Browse the repository at this point in the history

  5. add autoconf-archive pkg to arch build config

    Alex Wilson committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    be43872 View commit details
    Browse the repository at this point in the history