Remove the GtkLockButton button and set sensitivity based on NTP status #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukefromdc
reviewed
May 21, 2024
There was a problem hiding this comment.
I got two UI changes this installed with no time sync daemon in my system:
1 the NTP sync slider instead of being greyed out is responsive and pops up an error dialg on attempt to turn it on.
2: The lock button still shows up in the dialog but always shows locked and cannot be unlocked
|
Any updates on this? |
|
Time is tight lately, and I will handle it when there is enough time |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #750
This is just a small change. There is a lot of immature code in
time-admin, and I will continue to optimize the code