Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gettext #256

Merged
merged 3 commits into from
Dec 28, 2019
Merged

Gettext #256

merged 3 commits into from
Dec 28, 2019

Conversation

yetist
Copy link
Member

@yetist yetist commented Dec 25, 2019

Migrate from intltools to gettext.
NOTE: I disabled ru.po and uk.po, they has errors when building.

@yetist yetist requested a review from a team December 25, 2019 05:15
@monsta
Copy link
Contributor

monsta commented Dec 25, 2019

NOTE: I disabled ru.po and uk.po, they has errors when building.

Oh, not again... I'll have a look.

@monsta
Copy link
Contributor

monsta commented Dec 25, 2019

Same old story...

mate-dictionary/src/gdict-window.c

  if (count == 0)
    message = g_strdup (_("No definitions found"));
  else
    message = g_strdup_printf (ngettext("A definition found",
					"%d definitions found",
					count),
		    	       count);

@sc0w: I forgot how you fixed similar issues without changing the code... uploaded modified .po file to Transifex?

@rbuj
Copy link
Contributor

rbuj commented Dec 25, 2019

ru.po: Russian (msgstr[0]: one, msgstr[1]: few, msgstr[2]: many, msgstr[3]: other)

 msgstr[0] "Найдено определение"
 msgstr[1] "Найдено %d определения"
 msgstr[2] "Найдено %d определений"
 msgstr[3] "Найдено %d определение"

missing %d in msgstr[0]

@rbuj
Copy link
Contributor

rbuj commented Dec 25, 2019

uk: same issue

msgstr[0] "знайдено визначення"
msgstr[1] "%d знайдено визначення"
msgstr[2] "%d знайдено визначень"
msgstr[3] "%d знайдено визначень"

missing %d in msgstr[0]

@sc0w
Copy link
Member

sc0w commented Dec 26, 2019

@mate-desktop/core-team

seems I don''t have permissions, but we can solve the problem changing the check here:

https://docs.transifex.com/translation-checks/setting-translation-checks

who can do the job?

@raveit65
Copy link
Member

I can't edit organization settings.
A single fixed *.mo file can be uploaded by an admin.
Bildschirmfoto zu 2019-12-26 16-36-22

@sc0w
Copy link
Member

sc0w commented Dec 26, 2019

@monsta

2019-11-15_02-29

@yetist I think the languages are fixed with 0568d8e , you can remove efc6be7 and rebase against master

@raveit65 we need to change the check to avoid more problems in the future, and the translations can be fixed by translators easily, I think we need to change this check

Screenshot-2019-12-10-at-10-16-22

@raveit65 btw, offtopic, can you add @yetist to Maintainers at transifex?

@raveit65
Copy link
Member

raveit65 commented Dec 26, 2019

@sc0w
I agree with you to change that, but i don't have access to this page.
According to this link https://docs.transifex.com/translation-checks/setting-translation-checks
it is under organization settings. I think only the owner of Mate at transifex can do that.
I have a feeling that this is @stefano-k

@sc0w
Copy link
Member

sc0w commented Dec 27, 2019

@yetist the patch for debian in travis can be disabled?

@yetist
Copy link
Member Author

yetist commented Dec 27, 2019

@yetist the patch for debian in travis can be disabled?

Yes, done.

@sc0w
Copy link
Member

sc0w commented Dec 27, 2019

@raveit65 why portuguese is disabled in searchtool in travis since the commit 1ee9d61 ?

@raveit65
Copy link
Member

Not a really new issue, sometimes building failed because of Portuguese language.
#210 (comment)

Copy link
Member

@sc0w sc0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sc0w sc0w requested a review from a team December 27, 2019 18:58
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • diff -uprN mate-utils-master.pot mate-utils.pot > diff-pot-files.patch
    shows me that all translations are there, and all desktop files have translator hints.

  • Installation/uninstallation to /usr/local/share/locale/*/LC_MESSAGES/*.mo works fine.

  • All necessary files are in a tarball generated by distcheck.

Thanks.

@raveit65 raveit65 merged commit 39243c5 into master Dec 28, 2019
@raveit65 raveit65 deleted the gettext branch December 28, 2019 10:52
@sc0w
Copy link
Member

sc0w commented Jan 5, 2020

@raveit65

I agree with you to change that, but i don't have access to this page.

The problem was solved, the settings was changed by https://www.transifex.com/user/profile/mauron/

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants