Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd icon #1472

Merged
merged 11 commits into from
Oct 1, 2024
Merged

Add systemd icon #1472

merged 11 commits into from
Oct 1, 2024

Conversation

ultram4rine
Copy link
Contributor

This adds icon for systemd units and for systemd-conf language from this extension. File extensions taken from Red Hat docs. Icon taken from systemd brand site.

Colors changed from #30D475 to #00E676 and from #201A26 to #212121 using converter.

Closes #1163

Previews

Dark:

image

Light:

image

@ultram4rine
Copy link
Contributor Author

In e917585 I try to follow up #1310 and make icon pixel perfect. Result is minimal, but I think it's a little better now, at least the brackets. On the screenshots below service is a new one, target is old.

Preview

Dark:

image

Light:

image

src/icons/fileIcons.ts Outdated Show resolved Hide resolved
@PKief PKief force-pushed the main branch 3 times, most recently from 640fb8a to d5912bb Compare November 18, 2023 10:31
Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@okineadev
Copy link
Contributor

When will we accept PR?

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Sep 29, 2024
Copy link
Contributor

github-actions bot commented Sep 29, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Sep 29, 2024

When will we accept PR?

The icon looks very tiny and is not following the grid:

image

Maybe we can improve this a little bit to make the icon visually better.

@PKief
Copy link
Member

PKief commented Sep 29, 2024

and color checks are failing too:

image

We should replace the white color with a light grey

@PKief
Copy link
Member

PKief commented Sep 29, 2024

Additionally, I've fixed the light mode for language ids. There was a problem before (probably due to some refactoring in the past): f532fb2

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PKief PKief merged commit 89bb74b into material-extensions:main Oct 1, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon request] .service files from systemd
3 participants