-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add folder icon for internal folder #1501
feat: add folder icon for internal folder #1501
Conversation
640fb8a
to
d5912bb
Compare
@PKief - any chance of getting this merged? |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
eeb4f0e
to
b2e0fe4
Compare
2ff604a
to
b1ad1d2
Compare
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
3269ef9
to
ab6f6c7
Compare
@okineadev @PKief - Rebased the PR and addressed review comments. Please validate and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if you could make the icon align to the grid. Please read through the contribution guidelines to adjust it accordingly.
You can check the alignment by using our Pixel Perfect Checker.
Let us know if you have any questions regarding it.
There are folder icons from the old version of material-icon-theme, we need to take the folder image from the new icons |
ed9ed26
to
55e5e9c
Compare
7918c28
to
7cb05b2
Compare
To improve the quality and to reduce the maintenance effort regular refactoring of the project is inevitable. As much as we appreciate your work and contribution in this pull request, we realised that it was created a while ago and some merge conflicts occurred. We have decided to close all PRs that no longer correspond to the current code base. This gives us the opportunity to provide a better overview of the remaining open PRs. We would like to offer you to update your changes to the main branch and reopen the PR if the contribution is still relevant for you. Please contact us, we will be happy to help you resolve any conflicts. Thank you for your attention and good collaboration. |
Motivation and Context
internal
is a common pattern across multiple languages and frameworksinternal
folder for internal packages [link]Changes in this PR
internal
folderplain grey
as it does not specific to any language or framework.folder-admin
icon(s)Screenshots (if appropriate):