Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add folder icon for internal folder #1501

Conversation

aryaag
Copy link

@aryaag aryaag commented May 6, 2022

Motivation and Context

  • The folder name internal is a common pattern across multiple languages and frameworks
  • Specifically, Golang uses the internal folder for internal packages [link]
  • But there were no icons associated with it (nor any open pull requests about it)

Changes in this PR

  • Add folder icon(s) for internal folder
  • Add icons for both open and closed state
  • Icon used is downloaded from materialdesignicons
  • The color scheme is plain grey as it does not specific to any language or framework.
    • Color scheme is same as the folder-admin icon(s)

Screenshots (if appropriate):

@aryaag
Copy link
Author

aryaag commented May 16, 2024

@PKief - any chance of getting this merged?

Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

icons/folder-internal-open.svg Outdated Show resolved Hide resolved
@PKief PKief force-pushed the main branch 2 times, most recently from eeb4f0e to b2e0fe4 Compare June 12, 2024 20:23
@PKief PKief force-pushed the main branch 2 times, most recently from 2ff604a to b1ad1d2 Compare July 5, 2024 17:31
@github-actions github-actions bot added the 🏞️ icons PR with new icons label Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@aryaag aryaag force-pushed the feature/add-icon-for-internal-folder branch from 3269ef9 to ab6f6c7 Compare September 13, 2024 12:59
@aryaag
Copy link
Author

aryaag commented Sep 13, 2024

@okineadev @PKief - Rebased the PR and addressed review comments. Please validate and merge.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if you could make the icon align to the grid. Please read through the contribution guidelines to adjust it accordingly.

You can check the alignment by using our Pixel Perfect Checker.

Let us know if you have any questions regarding it.

@okineadev
Copy link
Member

I was wondering if you could make the icon align to the grid. Please read through the contribution guidelines to adjust it accordingly.

You can check the alignment by using our Pixel Perfect Checker.

Let us know if you have any questions regarding it.

There are folder icons from the old version of material-icon-theme, we need to take the folder image from the new icons

@PKief PKief force-pushed the main branch 2 times, most recently from ed9ed26 to 55e5e9c Compare September 20, 2024 19:17
@PKief PKief force-pushed the main branch 2 times, most recently from 7918c28 to 7cb05b2 Compare November 13, 2024 14:45
@PKief PKief added the 🚨 merge conflicts PR has merge conflicts label Jan 4, 2025
@PKief
Copy link
Member

PKief commented Jan 4, 2025

To improve the quality and to reduce the maintenance effort regular refactoring of the project is inevitable. As much as we appreciate your work and contribution in this pull request, we realised that it was created a while ago and some merge conflicts occurred.

We have decided to close all PRs that no longer correspond to the current code base. This gives us the opportunity to provide a better overview of the remaining open PRs.

We would like to offer you to update your changes to the main branch and reopen the PR if the contribution is still relevant for you. Please contact us, we will be happy to help you resolve any conflicts.

Thank you for your attention and good collaboration.

@PKief PKief closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons 🚨 merge conflicts PR has merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants