Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon Request] Taskfile #1739

Merged
merged 11 commits into from
Oct 30, 2023
Merged

[Icon Request] Taskfile #1739

merged 11 commits into from
Oct 30, 2023

Conversation

dhanielsales
Copy link
Contributor

@dhanielsales dhanielsales commented Oct 28, 2022 •
edited
Loading

Add support to Taskfile task runner.

References:
https://taskfile.dev/

The icon is based on Taskfile logo.

Special thanks to my wife Yanka. She made the icons 😄

@dhanielsales dhanielsales changed the title Feat/taskfile feat: add support to Taskfile Oct 28, 2022
@PKief PKief linked an issue Nov 4, 2022 that may be closed by this pull request
[Icon Request] Taskfile #1754
Closed
2 tasks
pd93
pd93 reviewed Nov 6, 2022
View reviewed changes
Copy link
Contributor

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I help to maintain Taskfile and was looking to add this change myself, but I see you (and your wife) have done all the hard work already. Thanks!

cc @andreynering

src/icons/folderIcons.ts Outdated Show resolved Hide resolved
@dhanielsales dhanielsales requested a review from pd93 December 13, 2022 00:14
pd93
pd93 reviewed Dec 13, 2022
View reviewed changes
src/icons/folderIcons.ts Outdated Show resolved Hide resolved
@dhanielsales dhanielsales requested a review from pd93 December 13, 2022 14:29
pd93
pd93 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@dhanielsales
Copy link
Contributor Author

@PKief Any news about this?

@GandelXIV
Copy link

This would be really nice!

@dhanielsales
Copy link
Contributor Author

@pd93
Is there any problem with this PR? Can i contribute with something else?

@dhanielsales dhanielsales mentioned this pull request Mar 18, 2023
Closed
2 tasks
@Igorgro
Copy link

Igorgro commented Mar 18, 2023

@PKief Is something blocking this PR?

@pd93
Copy link
Contributor

pd93 commented Mar 18, 2023

Is there any problem with this PR? Can i contribute with something else?

@dhanielsales I'm happy with PR this as-is, but I'm only a maintainer of Task, not this project, so there isn't much I can do. We just have to wait for @PKief or another maintainer to have some time to review.

@dhanielsales
Copy link
Contributor Author

Is there any problem with this PR? Can i contribute with something else?

@dhanielsales I'm happy with PR this as-is, but I'm only a maintainer of Task, not this project, so there isn't much I can do. We just have to wait for @PKief or another maintainer to have some time to review.

No problem man, I asked more directed to the theme maintainers, but i forgot to tag them, sorry 😅

@dhanielsales dhanielsales changed the title feat: add support to Taskfile [Icon Request] Taskfile Oct 11, 2023
@PKief
Copy link
Member

PKief commented Oct 18, 2023

I'm sorry you had to wait so long. Basically, the icon looks good and I will review it in more detail soon. I have put it on my list. If everything works out I will try to include it in the next update.

@PKief PKief self-requested a review October 29, 2023 11:59
@PKief PKief merged commit bdbfbc7 into material-extensions:main Oct 30, 2023
3 checks passed
@dhanielsales dhanielsales deleted the feat/taskfile branch October 30, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

@pd93 pd93 pd93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] Taskfile
5 participants
@dhanielsales @GandelXIV @Igorgro @pd93 @PKief