Added Lottie Folder Icons aswell as the File Icon. #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so confused on why the ubuntu and windows checks failed? |
|
Maybe extra space in fileIcons.ts? |
|
Also check #2044 |
What do you mean by more space? Like space out the file icon more? Or add more spaces in the fileIcons.ts? |
|
From fileIcons on line 2410:
Try and remove the extra space between the comma and fileExtensions.
|
|
@nijeff27 thank you so much for helping me! |
PKief
approved these changes
Nov 7, 2023
This was referenced Nov 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the Lottie folder icon for files named as "lottie", "lotties", and "lottiefiles". I also added the file icon for all .lottie files. Useful for app/web developers who are adding some lightweight animations to their application/website.