Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file icon for Vedic Programming Language. #2111

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

KunalSin9h
Copy link
Contributor

Vedic Programming Language Homepage: https://github.com/vedic-lang/

@PKief PKief self-requested a review October 31, 2023 12:13
@KunalSin9h
Copy link
Contributor Author

@PKief it shows invalid color, should i change the color or it can be merged?

@PKief
Copy link
Member

PKief commented Oct 31, 2023

@KunalSin9h yes, it would be good if you could adjust the color. You can use the Material color converter to find the correct color: https://pkief.com/material-color-converter/. And can you also add some more whitespace around the icon, according to this description: https://github.com/PKief/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#icon-spacing. Would be very nice if you can adjust this. If you need any help, please let me know.

@KunalSin9h
Copy link
Contributor Author

KunalSin9h commented Oct 31, 2023

@PKief fix both size and color

@PKief PKief force-pushed the main branch 3 times, most recently from 640fb8a to d5912bb Compare November 18, 2023 10:30
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me :)

@PKief PKief merged commit d27036b into material-extensions:main Jan 7, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@PtPrashantTripathi
Copy link

Thanks @KunalSin9h for this

@KunalSin9h
Copy link
Contributor Author

Thanks @PtPrashantTripathi for vedic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants