-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add file icon for Vedic
Programming Language.
#2111
Conversation
@PKief it shows invalid color, should i change the color or it can be merged? |
@KunalSin9h yes, it would be good if you could adjust the color. You can use the Material color converter to find the correct color: https://pkief.com/material-color-converter/. And can you also add some more whitespace around the icon, according to this description: https://github.com/PKief/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#icon-spacing. Would be very nice if you can adjust this. If you need any help, please let me know. |
@PKief fix both size and color |
640fb8a
to
d5912bb
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, it looks good to me :)
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Thanks @KunalSin9h for this |
Thanks @PtPrashantTripathi for vedic |
Vedic
Programming Language Homepage: https://github.com/vedic-lang/