Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nuxt icons #2119

Merged
merged 3 commits into from
Nov 20, 2023
Merged

update nuxt icons #2119

merged 3 commits into from
Nov 20, 2023

Conversation

stefanobartoletti
Copy link
Contributor

Update nuxt icons according to the new branding

https://nuxt.com/design-kit

@PKief PKief force-pushed the main branch 3 times, most recently from 640fb8a to d5912bb Compare November 18, 2023 10:30
@stefanobartoletti
Copy link
Contributor Author

stefanobartoletti commented Nov 20, 2023

Hey @PKief it's been a while since I opened this PR, and I'd like to cleanup my dashboard.

Can you please tell me if this is a wanted addition? And in that case, if this PR is ok or if it needs some edits?

(Same thing for some other PR's that I made in the past, that maybe need to be updated: #2118, #1016, #1011)

Thank you :)

Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks ok even if the contrast is not so good as in the previous icons. But let's go with the flow. You can close the other ones #2118, #1016, #1011, I don't like them, they are very specific and I guess they are not commonly used.\

The criticism has nothing to do with your work, sometimes it just doesn't fit. I really appreciate the effort you have put into it. Thank you for that.

@PKief PKief merged commit b088f9e into material-extensions:main Nov 20, 2023
4 checks passed
Copy link
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@stefanobartoletti
Copy link
Contributor Author

Thanks for this, if you want to tweak the colors I can try to see if I can find a better combination.

About the other PRs, no problems at all, the dude abides ;-)

Like I said I only wanted to declutter a bit my dashboard and I have no problems in closing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants