Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add postgres icon #2169

Merged
merged 3 commits into from
Dec 26, 2023
Merged

feat: add postgres icon #2169

merged 3 commits into from
Dec 26, 2023

Conversation

grehnen
Copy link
Contributor

@grehnen grehnen commented Dec 8, 2023

For .plpgsql files

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Dec 23, 2023

it's better to use the already existing database icon here, as the PostgreSQL is not so suitable to be used as file icon here:

image

@PKief PKief self-requested a review December 23, 2023 10:31
@PKief PKief merged commit 944903f into material-extensions:main Dec 26, 2023
2 checks passed
Copy link
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@Ymirke
Copy link

Ymirke commented Aug 17, 2024

Would love to have something in this style for postgres folders
POSTGRES DB

@lucas-labs
Copy link
Member

@Ymirke the problem with that is that the logo would be impossible to recognize when rendered at 16x16px. We would be rendering a complex logo in 8 squared pixels.

If what you really want is to be able to differentiate between let's say .plpgsql and .sql files, an alternative could be to use Icon Cloning assigning a different color for the .plpgsql file name extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants