Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLoC folder icon #2586

Closed
wants to merge 0 commits into from
Closed

BLoC folder icon #2586

wants to merge 0 commits into from

Conversation

nulkode
Copy link
Contributor

@nulkode nulkode commented Sep 10, 2024

Description

Added BLoC folder icon.

Closes #2585.
Closes #1461.

Contribution Guidelines

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief force-pushed the main branch 2 times, most recently from ed9ed26 to 55e5e9c Compare September 20, 2024 19:17
@nulkode
Copy link
Contributor Author

nulkode commented Oct 5, 2024

@PKief sorry for mentioning, but can I get some feedback or can I get this merged?

@PKief
Copy link
Member

PKief commented Oct 6, 2024

@PKief sorry for mentioning, but can I get some feedback or can I get this merged?

The motive of this folder icon is a little different to all of the other folder icons of this extension. It has too many colors and this black border, which is not looking good and not consistent to the other folder icons.

Please take a look at the contribution guidelines to get more information on how to design good folder icons.

@PKief PKief force-pushed the main branch 2 times, most recently from 7918c28 to 7cb05b2 Compare November 13, 2024 14:45
@nulkode
Copy link
Contributor Author

nulkode commented Dec 24, 2024

@PKief done, I believe that now the motive fits better with the other folder icons.

@PKief PKief force-pushed the main branch 3 times, most recently from bf847b7 to be76a6a Compare January 6, 2025 21:18
@PKief PKief closed this Jan 6, 2025
@PKief

This comment was marked as outdated.

@PKief PKief mentioned this pull request Jan 6, 2025
2 tasks
@PKief
Copy link
Member

PKief commented Jan 6, 2025

I've created a follow up PR:
#2795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: BLoC [Icon Request] Flutter Bloc State Management
2 participants