-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add C3 image #2655
feat: Add C3 image #2655
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr!
If vscode integration exists for c3 (e.g. an extension that adds color highlighting, etc), they surely defined a languageId
for the c3 language.
So, we should also add the mapping to src/core/icons/languageIcons.ts
Yeah they have one but not officially in vscode yet. So don't know if you already want it in the |
Sorry for all those commits. At this moment I think I am done with it. |
Yeah, the only way to fit both the C and the 3 is to not use left and right margins. IMO, this shouldn't be an issue here, at least as an exception. I find bottom and top margins more important, as they help to avoid icons to be too close to each other when displayed vertically in the file tree. The last version by @StandUp2001 does that (almost not using horizontal margins) and it look pretty good IMO (although, it's not pixel perfect, but that can be fixed). What do you guys think? |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
Description
Add a new icon for
c3
infileIcons
array insrc/core/icons/fileIcons.ts
Contribution Guidelines