Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(icons)!: update kotlin icon to latest version #2666

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

NahNathan
Copy link
Contributor

Description

  • Updated the Kotlin icon (kotlin.svg) in the icons directory to the latest version, reflecting the design changes introduced in 2021.
  • This update enhances visual alignment with the official Kotlin branding in the VS Code Material Icon Theme.

Contribution Guidelines

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Nov 3, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Copy link
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for the PR.

All icons in this extension use colors from the Material Palette (more info here).

There's a CI workflow that makes sure that all colors used in the svgs are from the material palette.

Take a look at my comment below.

icons/kotlin.svg Outdated Show resolved Hide resolved
icons/kotlin.svg Outdated Show resolved Hide resolved
Co-authored-by: Okinea Dev <[email protected]>
Signed-off-by: Nathan Rodrigues dos Santos <[email protected]>
@okineadev okineadev changed the title chore(icon): update Kotlin icon to latest version chore(icons)!: update kotlin icon colors to latest version Nov 4, 2024
@okineadev okineadev enabled auto-merge (squash) November 4, 2024 13:06
@okineadev okineadev requested a review from lucas-labs November 4, 2024 13:07
@okineadev okineadev changed the title chore(icons)!: update kotlin icon colors to latest version chore(icons)!: update kotlin icon to latest version Nov 4, 2024
@okineadev okineadev merged commit 0ecde34 into material-extensions:main Nov 4, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants