Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ icon for ruff config file #2766

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

lucas-labs
Copy link
Member

Description

File Icon for ruff config file.

Closes: #2755

Contribution Guidelines

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Dec 26, 2024
Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@lucas-labs
Copy link
Member Author

lucas-labs commented Dec 26, 2024

In my fork, I had two variations for light and dark themes using light green and purple, both quite similar to those used in the ruff logo:

image

image

But here I went with a 1 svg file solution using a darker green.

Let me know what you guys think.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always prefer it, if we keep it simple and have a single color for dark and light theme only. So from my point of view this icon looks very nice. Thanks for the contribution!

@PKief PKief merged commit 0aa0a9b into material-extensions:main Jan 1, 2025
5 checks passed
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: ruff config file
2 participants