Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): 🔖 add appropriate labels to PRs with failed checks #2793

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

PKief
Copy link
Member

@PKief PKief commented Jan 6, 2025

Description

Follow up of #2785.


Add steps to workflows to manage labels based on workflow results.

This will provide a convenient understanding of the problem with PR

  • Color Check Workflow:

    • Add permission to write pull requests.
    • Add step to manage invalid-colors label based on color check result.
  • Build Workflow:

    • Add permission to write pull requests.
    • Add step to manage invalid-build label based on build result.
  • PR Title Workflow:

    • Add step to manage invalid-title label based on PR title check result.

For more details, open the Copilot Workspace session.

Contribution Guidelines

@github-actions github-actions bot added the 🔄 workflows GitHub Actions label Jan 6, 2025
@github-actions github-actions bot added the 🏞️ icons PR with new icons label Jan 7, 2025
@github-actions github-actions bot added the 🎨 invalid colors The icon has wrong colors label Jan 7, 2025
@okineadev
Copy link
Member

okineadev commented Jan 7, 2025

alhamdulillah

@github-actions github-actions bot added the ❌ failed build Failed build label Jan 7, 2025
This reverts commit 43c9c6f.
This reverts commit a73b0cf.
@okineadev okineadev removed ❌ failed build Failed build 🎨 invalid colors The icon has wrong colors labels Jan 7, 2025
@material-extensions material-extensions deleted a comment from github-actions bot Jan 7, 2025
@okineadev
Copy link
Member

I think everything is working now

@okineadev okineadev requested a review from Copilot January 7, 2025 08:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/scripts/update-status-label.sh: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/color-check.yml:42

  • [nitpick] The label name '🎨 invalid colors' is unclear. Consider renaming it to something more descriptive like 'Invalid Color Scheme'.
run: .github/scripts/update-status-label.sh ${{ github.event.pull_request.number }} ${{ steps.color-check.outcome }} "🎨 invalid colors"

.github/workflows/color-check.yml:41

  • Ensure that the new behavior of managing labels based on color check result is covered by tests.
if: always()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons 🔄 workflows GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants