-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Customize workspace folder icons #2807
Draft
PKief
wants to merge
9
commits into
main
Choose a base branch
from
PKief/issue2804
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🏞️ icons
PR with new icons
💱 translations
Issues related to translating the project into other languages
📝 docs
Related to improving or adding documentation
labels
Jan 12, 2025
PKief
added
✨ enhancement
Enhancement
💱 translations
Issues related to translating the project into other languages
📝 docs
Related to improving or adding documentation
and removed
🏞️ icons
PR with new icons
💱 translations
Issues related to translating the project into other languages
📝 docs
Related to improving or adding documentation
labels
Jan 12, 2025
1 task
okineadev
approved these changes
Jan 18, 2025
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📝 docs
Related to improving or adding documentation
✨ enhancement
Enhancement
🏞️ icons
PR with new icons
💱 translations
Issues related to translating the project into other languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the feature of customizing workspace folder icons:
It makes use of all existing features including color changing and cloning. So it's possible to give every icon an individual touch if needed. Both user settings for local customization as well as preconfigured via "folderIcons.ts" is supported.
I made the experience that workspace folder are usually very individual. That's why we should keep the default folder icon here. If people want to change the behavior they can adjust it in their user settings.
Todos:
rootFolderNames
androotFolderNamesExpanded
to the manifestContribution Guidelines