-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract Model and some fixes #6
Conversation
…awin into nonisothermal_fixes
…o diffusion in precipitate fix
I'm starting to go through this now. The diff is so big and touches so much of the codebase, I'm not going to bother to try to go through the diff itself. I've pulled the PR branch and I've started going through it separately. Here is my list of what I'm reviewing:
|
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Code coverage isn't in the default branch yet, so we don't get the in-PR report, but you can see the results here: https://app.codecov.io/gh/materialsgenomefoundation/kawin/tree/nonisothermal_fixes @nury12n Do you think you could add additional tests and get total coverage up to, let's say, 60-70%? I recommend focusing attention on the precipitation module. |
This is a fairly large refactor of kawin which implements an abstract GenericModel object that the precipitate and diffusion models inherit.
Changes
Documentation is currently in progress. But once we merge this to the main branch and I finish the documentation, I will most likely officially release this to kawin 0.3.0