-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate enums in Github Actions #1095
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
===========================================
- Coverage 90.18% 72.54% -17.65%
===========================================
Files 147 77 -70
Lines 14174 5059 -9115
===========================================
- Hits 12783 3670 -9113
+ Misses 1391 1389 -2 ☔ View full report in Codecov by Sentry. |
I'm not seeing the use of |
I'll also close #1094 in favor of this |
sorry, that's |
@tschaume,
I'd like to take a crack at having the action generate a yaml file, and instantiating the enums from yaml. I'll make a separate PR for that |
91f51c5
to
35105fb
Compare
centralize to enum generation to dev_scripts standardize yaml config names
35105fb
to
dd3bc72
Compare
7359562
to
1807747
Compare
1ad70df
to
7bfc2a2
Compare
8a5eb0e
to
f4dad6a
Compare
1ad2db3
to
f142585
Compare
@esoteric-ephemera @tsmathis Regenerating the enums removes the
_missing_
classmethod for the VASP calc types. Is that being used/needed anywhere?