Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use pydantic-settings secrets feature for maggma credentials #451

Open
Andrew-S-Rosen opened this issue Oct 10, 2023 · 0 comments

Comments

@Andrew-S-Rosen
Copy link
Member

We should think about a slightly more secure mechanism for storing database secrets both in Jobflow configuration files. This is specifically referring to maggma-based credentials.

My proposed recommendation is to use the secrets management features of pydantic-settings, as discussed here (also see this page). Of course, there's no way of avoiding storing some credential somewhere, but this seems like a slightly better approach. That way, if someone shares their config file with someone else without thinking (or even posts it on GitHub), their credentials won't be directly exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant