Tidy, update, and document Crystal Toolkit scene generation code #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removal of `ColladaExporter` (deprecated in favor of GLTF/GLB, which are the latest industry standards). All geometries are now `BufferGeometry` by default, so constructors have been renamed.
|
this is awesome @mkhorton thanks for the PR. Let me know if you want to coordinate on some parts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few new features in Crystal Toolkit I'd like to implement, but I noticed the corresponding JavaScript code hadn't been updated in a while and thought some early spring cleaning might help :)
Creating this PR in draft until it's ready to merge, but includes:
three.jsfrom 0.139 to 0.160parcel(build tool) and some small updates to make sure code still builds with latest versionColladaExporter, deprecated in favor of GLTF/GLB which are actively maintained and more recent standardsSceneSettingsto make it easier to see what is configurableobjectJson.origin