v2024.3.1

materialsproject · Mar 1, 2024 · 442d740 · 442d740
1 parent 83806df
commit 442d740
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 7 deletions.
diff --git a/docs/CHANGES.md b/docs/CHANGES.md
diff --git a/pymatgen/io/vasp/sets.py b/pymatgen/io/vasp/sets.py
@@ -2902,7 +2902,7 @@ def batch_write_input(
 )
 
 
-def get_valid_magmom_struct(structure, inplace=True, spin_mode="auto"):
+def get_valid_magmom_struct(structure: Structure, inplace: bool = True, spin_mode: str = "auto") -> Structure:
     """
     Make sure that the structure has valid magmoms based on the kind of calculation.
 
@@ -2943,17 +2943,15 @@ def get_valid_magmom_struct(structure, inplace=True, spin_mode="auto"):
     else:
         mode = spin_mode[0].lower()
 
-    new_struct = structure.copy() if not inplace else structure
-    for site in new_struct:
+    ret_struct = structure if inplace else structure.copy()
+    for site in ret_struct:
         if mode == "n":
             if "magmom" in site.properties:
                 site.properties.pop("magmom")
         elif "magmom" not in site.properties or site.properties["magmom"] is None:
             site.properties["magmom"] = default_values[mode]
 
-    if not inplace:
-        return new_struct
-    return None
+    return ret_struct
 
 
 @dataclass

diff --git a/setup.py b/setup.py
@@ -25,7 +25,7 @@
 setup(
     name="pymatgen",
     packages=find_namespace_packages(include=["pymatgen.*", "pymatgen.**.*", "cmd_line"]),
-    version="2024.2.23",
+    version="2024.3.1",
     python_requires=">=3.9",
     install_requires=[
         "matplotlib>=1.5",