Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 support #3885

Closed
wants to merge 6 commits into from
Closed

Numpy 2.0 support #3885

wants to merge 6 commits into from

Conversation

shyuep
Copy link
Member

@shyuep shyuep commented Jun 17, 2024

This PR updates pymatgen to support np 2.0. As of now, tests pass on most systems except for some binary incompatibility issues. This PR should be merged only when all tests pass.

@DanielYang59
Copy link
Contributor

As of now, tests pass on most systems except for some binary incompatibility issues.

Thanks for taking us to NumPy 2! Just a gentle reminder, the actual installed numpy in CI tests for Ubuntu is still version 1.26.4:
image

And the numpy installed for macos is 1.25.0:

image

@janosh janosh force-pushed the master branch 2 times, most recently from e3fbc67 to 41e6d99 Compare August 3, 2024 19:01
Signed-off-by: Shyue Ping Ong <[email protected]>
@janosh janosh closed this Aug 22, 2024
@janosh janosh deleted the np2 branch August 22, 2024 10:52
@janosh
Copy link
Member

janosh commented Aug 22, 2024

obsolete with merging of #3894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants