Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding discrete topologies, uniformities, and metrics to the hierarchy. Cleans up a bunch of pre-HB issues, and now we can use
bool
directly instead of through a bunch of aliases. We can now just writecantor_space = prod_topology (fun=> bool)
andUniform.on cantor_space
. Pretty nice!However, I encountered a lot of weird HB errors. I put in tickets math-comp/hierarchy-builder#447 and math-comp/hierarchy-builder#446
Furthermore, I could only get this to compile with a call to
HB.saturate
. This is fine, except that it the commands takes several minutes to run. And is broken on master with errorI am skeptical if I get a build that works on both master and the current release
Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers