Add support for an immediate "press" event callback #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debounce the button state, not just the pin state. This way debounce() will know if it's pressed or not pressed. Also, enable a negative ms value so it will only debounce the state on inactive. This way a button press will be recognized instantly. Deactivating the button press will still be subject to the debounce time, preventing switch "noise" from propagating through to the _fsm.
These should be boolean values, since they are passed into _fsm() which expects bool. Otherwise the (previous) default value of -1 will be interpreted by the _fsm() as being 'true' (not 0).
Add support for a callback immediately when detecting a press, rather than the alternatives of waiting for a release or a long press.
Tidy up a single-line if-statement.
|
Each commit is commented. This should solve Issue #139. |
mathertel
requested changes
May 27, 2024
Update readme to reflect the changes.
mathertel
approved these changes
May 27, 2024
|
Thanks Matthew @mattallen37. |
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.