Fix issue with calling removed legacy function #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed it for me! Thanks. |
|
hi @mathertel I think there might still be a small problem: The release name at https://github.com/mathertel/OneButton/releases is not "2.6.1" but instead "fixing compilation issue ...". This breaks the github 'release' resolution that platformio uses to find releases (it only sees 2.6.0 as the latest release). For instance look what github says is the latest release on https://github.com/mathertel/OneButton. Awesome project btw. cc @thebentern |
|
Renamed. So it should work now hopefully
/ Matthias Hertel
…________________________________
From: geeksville ***@***.***>
Sent: Friday, August 2, 2024 8:52:15 PM
To: mathertel/OneButton ***@***.***>
Cc: Matthias Hertel ***@***.***>; Mention ***@***.***>
Subject: Re: [mathertel/OneButton] Fix issue with calling removed legacy function (PR #148)
hi @mathertel<https://github.com/mathertel> I think there might still be a small problem:
The release name at https://github.com/mathertel/OneButton/releases is not "2.6.1" but instead "fixing compilation issue ...". This breaks the github 'release' resolution that platformio uses to find releases (it only sees 2.6.0 as the latest release). For instance look what github says is the latest release on https://github.com/mathertel/OneButton.
Awesome project btw.
cc @thebentern<https://github.com/thebentern>
—
Reply to this email directly, view it on GitHub<#148 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIJTFZIKAZTVTVEHHN6VETZPPIN7AVCNFSM6AAAAABL4PI3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVHE2TQOBRHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@mathertel may need to mark 2.6.1 as latest, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Hi from the Meshtastic project 👋 😄