Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing evaluation from atLeast.Resumed to atLeast.Started #87

Merged
merged 1 commit into from
May 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ class ObserveWrapper<T> internal constructor() {
val observer = object : Observer<DataResult<T>?> {
override fun onChanged(value: DataResult<T>?) {
scope.launchWithErrorTreatment {
handleResult(value) { owner.lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED) }
handleResult(value) { owner.lifecycle.currentState.isAtLeast(Lifecycle.State.STARTED) }
if (eventList.isEmpty()) {
liveData.removeObserver(this)
}
Expand Down Expand Up @@ -1110,7 +1110,11 @@ class ObserveWrapper<T> internal constructor() {

// Handle Loading
event is LoadingEvent -> event.run {
wrapper.handle(isLoading, transformDispatcher, evaluateBeforeDispatch) && isLoading.not()
wrapper.handle(
isLoading,
transformDispatcher,
evaluateBeforeDispatch
) && isLoading.not()
}

// Handle ShowLoading
Expand All @@ -1135,7 +1139,11 @@ class ObserveWrapper<T> internal constructor() {

// Handle Data
event is DataEvent -> (event as DataEvent<T>).wrapper.let {
it.handle(result.data, transformDispatcher, evaluateBeforeDispatch) && (result.data != null)
it.handle(
result.data,
transformDispatcher,
evaluateBeforeDispatch
) && (result.data != null)
}

// Handle Empty
Expand Down
Loading