Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key backend refinements #134

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Key backend refinements #134

merged 5 commits into from
Mar 16, 2024

Conversation

mathiasertl
Copy link
Owner

Key backends:

  • Add support for multiple configured storages backends.
  • Pass the CA when loading parent model for parent private keys and for using private keys. This means that settings.CA_PASSWORDS is now honored in init_ca and a few other places where it wasn't before.
  • Bugfix: get the right key backend when loading it via the model instance.

Other changes:

mathiasertl
mathiasertl commented Mar 16, 2024
View reviewed changes
ca/django_ca/key_backends/base.py
"""Get options to create private keys into a Pydantic model.
def get_use_parent_private_key_options(
self, ca: "CertificateAuthority", options: Dict[str, Any]
) -> UsePrivateKeyOptionsTypeVar:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushaldas note interface change here

ca/django_ca/key_backends/base.py
def get_use_private_key_options(self, options: Dict[str, Any]) -> UsePrivateKeyOptionsTypeVar:
"""Get options to create private keys into a Pydantic model.
def get_use_private_key_options(
self, ca: Optional["CertificateAuthority"], options: Dict[str, Any]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushaldas note interface change here

@mathiasertl mathiasertl changed the title Feature/1.28.0 ca backends refinement Key backend refinements Mar 16, 2024
@mathiasertl mathiasertl merged commit 9504394 into main Mar 16, 2024
108 checks passed
@mathiasertl mathiasertl deleted the feature/1.28.0-ca-backends-refinement branch March 16, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mathiasertl