Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode package #263

Merged
merged 8 commits into from
Jun 3, 2019
Merged

Unicode package #263

merged 8 commits into from
Jun 3, 2019

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented May 26, 2019

Port of the MJ2 unicode package.
I added a property in UnicodeConfiguration to retain information for later semantic processing

@zorkow zorkow requested a review from dpvc May 26, 2019 22:21
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment for the future, and one import that doesn't seem to be needed.

@zorkow zorkow mentioned this pull request Jun 3, 2019
12 tasks
@zorkow zorkow merged commit fe3161f into fix_surrogates Jun 3, 2019
@zorkow zorkow deleted the unicode_package branch June 3, 2019 18:22
@zorkow zorkow restored the unicode_package branch June 3, 2019 18:33
@zorkow
Copy link
Member Author

zorkow commented Jun 3, 2019

@dpvc I screwed up the merge by not rebasing to master first. I'll redo the PR and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants